Refactor strings.NewReader into bytes to avoid allocations
#659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
refactor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code to use bytes.NewReader instead of strings.NewReader, thereby reducing unnecessary allocations. It also standardizes error message formatting in the database module.
- Replace string-based readers with byte-based readers
- Update error message capitalization for consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/logging/splunk.go | Changed from strings.NewReader(string(jsonEvents)) to bytes.NewReader(jsonEvents) |
| pkg/logging/logstash.go | Replaced strings.NewReader(string(data)) with bytes.NewReader(data) |
| pkg/logging/graylog.go | Updated strings.NewReader to bytes.NewReader for JSON messages |
| pkg/logging/elastic.go | Refactored error index request body to use bytes.NewReader(jsonEvent) |
| pkg/logging/db.go | Adjusted error message capitalization for consistent logging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using
strings.NewReaderwhenbytes.NewReadercan be used and avoid unnecessary allocation.